Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-37087][doc] Add docs for alter materialized table as query #26064

Merged
merged 5 commits into from
Feb 10, 2025
Merged

[FLINK-37087][doc] Add docs for alter materialized table as query #26064

merged 5 commits into from
Feb 10, 2025

Conversation

hackergin
Copy link
Contributor

@hackergin hackergin commented Jan 23, 2025 •
edited
Loading

What is the purpose of the change

Add docs for alter materialized table as query

Brief change log

  • Add docs for alter materialized table as query

Verifying this change

This change only contains document change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@hackergin hackergin force-pushed the FLINK-37087 branch 4 times, most recently from 3217e5f to 9036d53 Compare January 23, 2025 13:08
davidradl
davidradl suggested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the REFRESH keyword is mentioned - there is a some explanation of this in the file but not how the partition piece works and when you would want to use it.
I see we have added SUSPEND and RESUME, it would be useful to describe or link to how these work - including how the supplied list of keys should be used.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 23, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@hackergin hackergin force-pushed the FLINK-37087 branch 4 times, most recently from 38fd3d0 to b2fdeb7 Compare January 24, 2025 09:21
@davidradl
Copy link
Contributor

Reviewed by Chi on 23/01/2025 Go back to the submitter with review comments.

lsyldliu
lsyldliu reviewed Jan 26, 2025
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackergin Thanks for your contribution, I left some comments.

docs/content/docs/dev/table/materialized-table/statements.md Outdated Show resolved Hide resolved
docs/content/docs/dev/table/materialized-table/statements.md Show resolved Hide resolved
docs/content/docs/dev/table/materialized-table/statements.md Show resolved Hide resolved
docs/content/docs/dev/table/materialized-table/statements.md Outdated Show resolved Hide resolved
docs/content.zh/docs/dev/table/materialized-table/statements.md Outdated Show resolved Hide resolved
docs/content.zh/docs/dev/table/materialized-table/statements.md Outdated Show resolved Hide resolved
docs/content.zh/docs/dev/table/materialized-table/statements.md Outdated Show resolved Hide resolved
docs/content.zh/docs/dev/table/materialized-table/statements.md Outdated Show resolved Hide resolved
docs/content.zh/docs/dev/table/materialized-table/statements.md Outdated Show resolved Hide resolved
@hackergin
Copy link
Contributor Author

I see that the REFRESH keyword is mentioned - there is a some explanation of this in the file but not how the partition piece works and when you would want to use it. I see we have added SUSPEND and RESUME, it would be useful to describe or link to how these work - including how the supplied list of keys should be used.

@davidradl This document is solely intended to explain how users can use it. If we need to introduce the underlying implementation to users, I think we should have a separate document to explain the overall process.

lsyldliu
lsyldliu approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsyldliu
Copy link
Contributor

@hackergin Can you help open a PR backport it to release-2.0 branch?

@lsyldliu lsyldliu merged commit 35df685 into apache:master Feb 10, 2025
hackergin added a commit to hackergin/flink that referenced this pull request Feb 10, 2025
@hackergin @lsyldliu
[FLINK-37087][doc] Add docs for alter materialized table as query (ap…
3d12684 
…ache#26064)

[FLINK-37087][doc] Add docs for alter materialized table as query

---------

Co-authored-by: Ron <[email protected]>
@hackergin hackergin mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidradl davidradl davidradl requested changes

@lsyldliu lsyldliu lsyldliu approved these changes

Assignees
No one assigned
Labels
component=Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hackergin @flinkbot @davidradl @lsyldliu